flagsmith icon indicating copy to clipboard operation
flagsmith copied to clipboard

Frontend docker image should build with static file to serve flags

Open matthewelwell opened this issue 2 years ago • 5 comments
trafficstars

Currently the frontend defaults to using the staging API for it's Flagsmith on Flagsmith configuration. We should build the image with a snapshot of the features at the time of building and then allow people to configure Flagsmith on Flagsmith as needed.

matthewelwell avatar Mar 28 '23 13:03 matthewelwell

@matthewelwell Question here, would we want that flag state to be in git? I guess that would be quite useful in a way (To see diffs). Either way this is really simple thanks to https://github.com/Flagsmith/flagsmith-cli

kyle-ssg avatar Mar 30 '23 06:03 kyle-ssg

@matthewelwell Question here, would we want that flag state to be in git? I guess that would be quite useful in a way (To see diffs). Either way this is really simple thanks to https://github.com/Flagsmith/flagsmith-cli

Yeah, I think it should live in git.

matthewelwell avatar Mar 30 '23 07:03 matthewelwell

Would we want the SDK to use this file as default flags? I thought it'd be useful but then realised that everyone would identify anyway, making it a bit pointless.

kyle-ssg avatar Mar 30 '23 07:03 kyle-ssg

I don't fully know how it works tbh, but what I'd like to happen is that all users logging in to the Flagsmith dashboard in a self hosted installation that hasn't configured Flagsmith on Flagsmith sees the features that we configure in this static file. Is that possible?

matthewelwell avatar Mar 30 '23 07:03 matthewelwell

The only way that's possible is if we prevent those users from identifying, since that would result in new flags being fetched. I'm not sure that's desirable in all cases?

kyle-ssg avatar Mar 30 '23 07:03 kyle-ssg