flagsmith icon indicating copy to clipboard operation
flagsmith copied to clipboard

Schedule changes tweaks / fixes

Open matthewelwell opened this issue 3 years ago • 4 comments

  • [ ] BE: Add live from date to list view of scheduled change
  • [x] BE: Allow a change request with no required approvers to be committed
  • [ ] FE: Show Clock icon in "Open" list if the CR is scheduled - Needs backend
  • [x] FE: Only show change requests in 'Scheduled' tab if they have been committed
  • [x] FE: Don't show "Open" tab if Env doesnt have 4 eyes enabled
  • [x] FE: Show number of scheduled change requests in aside rather than open when 4eyes is disabled
  • [x] FE: Change usage of 'publish / published' to 'schedule / scheduled' in all copy
  • [x] FE: Show scheduled live date in detail view
  • [x] FE: Scheduled changes in environments with 4 eyes disabled are displayed in the 'Closed' tab immediately after creation

matthewelwell avatar Apr 29 '22 13:04 matthewelwell

As discussed, for the issue regarding the 'closed' tab, I'll add a live_from_before parameter, so the tabs will map to the following requests:

Open - GET /api/v1/environments/:key/list-change-requests/?committed=0
Scheduled - GET /api/v1/environments/:key/list-change-requests/?committed=1&live_from_after=now()
Closed - GET /api/v1/environments/:key/list-change-requests/?committed=1&live_from_before=now()

matthewelwell avatar Apr 29 '22 13:04 matthewelwell

Great,

Requests are as follows now: open, closed, scheduled image

I've noticed however, I can no longer commit a change request that requires no approvals, which is necessary for scheduling without 4 eyes.

image

kyle-ssg avatar Apr 30 '22 09:04 kyle-ssg

https://github.com/Flagsmith/flagsmith/pull/1109

gagantrivedi avatar May 13 '22 11:05 gagantrivedi

https://github.com/Flagsmith/flagsmith-workflows/pull/9

gagantrivedi avatar May 13 '22 11:05 gagantrivedi