flagsmith-dotnet-client icon indicating copy to clipboard operation
flagsmith-dotnet-client copied to clipboard
verified publisher icon Flagsmith

feat: Deprecate constructors with >1 parameter and IFlagsmithConfig interface. Add EnableLocalEvaluation and EnvironmentRefreshInterval properties

Open rolodato opened this issue 11 months ago • 1 comments

Fixes https://github.com/Flagsmith/flagsmith-dotnet-client/issues/135.

Validated this does not break existing code by running the existing test suite without changes: https://github.com/Flagsmith/flagsmith-dotnet-client/pull/136/commits/0b41d2b7edcf26ac218f369e399335717637830f

rolodato avatar Jan 21 '25 19:01 rolodato

I've left a few comments but overall looks good. I'm not sure if this comment from the PR description is still valid though as it looks like there have been more changes to client / interface since then?

I added the previous tests as they're currently in main here: https://github.com/Flagsmith/flagsmith-dotnet-client/pull/136/commits/1753943b34349a6fdd201ec814a4f196d185c22e. We can delete this in the following major version.

rolodato avatar Apr 03 '25 19:04 rolodato