flagsmith-charts icon indicating copy to clipboard operation
flagsmith-charts copied to clipboard

Creating edge-proxy helm chart

Open BennyG93 opened this issue 1 year ago • 3 comments

Thanks for submitting a PR! Please check the boxes below:

  • [x] I have filled in the "Changes" section below?
  • [x] I have filled in the "How did you test this code" section below?
  • [ ] I have bumped the version number in /charts/flagsmith/Chart.yaml in the section version or I'm merging to a release branch

Changes

Creating a helm chart for deploying the Flagsmith Edge Proxy to Kubernetes.

Explanation: The chart was initially created using the helm create...

Users can write their proxy configuration in edgeProxy.configMap.content or provide the name of an existing configmap that has their configuration to edgeProxy.configMap.name.

The chart will create a Volume using this ConfigMap and mount it to each container at the path /app/config.json.

How did you test this code?

We have deployed this chart to our infra.

  • Clone the repo.
  • Edit/create a values.yaml file and add your configuration to edgeProxy.configMap.content.
  • Optionally add an ingress config to access the service.
  • Install the helm chart, e.g. helm install -f myvalues.yaml edge-proxy ./edge-proxy
  • Test the proxy response.

This is an initial attempt, hopefully it provides a solution for anyone who wants to self host the proxy service on Kubernetes.

BennyG93 avatar Oct 03 '24 09:10 BennyG93

Changes look good but please take a look at the linting failures in CI.

Hey @zachaysan - I noticed the failing CI check as well, its failing because it wants me to bump the flagsmith chart version.

 ✔︎ edge-proxy => (version: "0.1.0", path: "charts/edge-proxy")
 ✖︎ flagsmith => (version: "0.59.0", path: "charts/flagsmith") > Chart version not ok. Needs a version bump!

I bumped it to make it work, but I guess you don't want to be bumping the version of a chart which is not being updated?

BennyG93 avatar Oct 09 '24 06:10 BennyG93

Thanks @BennyG93, yeah, this is a similar problem to one that we've been putting off for too long (well, it just exacerbates the problem really). I think it's finally time to integrate release-please here @khvn26 ?

Maybe we can merge this PR first and just accept the pointless bump on the flagsmith version though, what do you think?

matthewelwell avatar Oct 09 '24 09:10 matthewelwell

My 2 cents here, if we merge this PR before that fix/change is made, then I guess whenever you update the main Flagsmith helm chart, it will ask you to bump this proxy chart as well. (and vice versa). So just consider that.

The other thing I can do when I have some time is to try and merge the templates of this chart inside the main Flagsmith chart so that it becomes more of an optional sub-component that can be enabled and disabled. With this approach, there will only be 1 chart and you can continue putting off the problem ;)

BennyG93 avatar Oct 09 '24 09:10 BennyG93