flagsmith-charts icon indicating copy to clipboard operation
flagsmith-charts copied to clipboard

Ability to add labels and annotations to all resources in helm chart

Open masmontanas opened this issue 1 year ago • 2 comments

It would be very helpful to expose a configuration for commonLabels and commonAnnotations in the helm chart so users can set labels and annotations on all resources created by the helm chart in one place.

We currently have some integration use-cases that require certain labels/annotations exist on all resources associated with a helm chart, and the pattern above is quite common for other helm charts in the k8s ecosystem.

We'd be happy to put in the PR ourselves if the maintainers agree with the pattern above.

Thanks!

masmontanas avatar Jan 08 '24 17:01 masmontanas

Hi @masmontanas, yes - this sounds like a good idea, we'd be more than happy to receive a PR on this.

It would be great if you could also submit a matching PR to update the documentation on our main repository too.

matthewelwell avatar Jan 08 '24 17:01 matthewelwell

Thanks @matthewelwell , our team will put in a PR for this likely tomorrow.

masmontanas avatar Jan 08 '24 19:01 masmontanas

@matthewelwell is this still outstanding?

danielloader avatar Aug 08 '24 13:08 danielloader

Sorry, no - this should have been closed. See the PR here.

matthewelwell avatar Aug 08 '24 16:08 matthewelwell