PKSM icon indicating copy to clipboard operation
PKSM copied to clipboard

Bug Report - Items get "deleted"

Open Diverscope opened this issue 2 years ago • 3 comments

Describe the bug When editing the contents of the bag of a gen4 Pokémon game and you delete one or multiple items, several items at the end of the bag (i.e the items at the very bottom) get "deleted". Deleted in quotation marks because they actually don't seem to get deleted, just hidden or not accessible ingame. If you add an item in the bag afterwards and reopen the bag menu in pksm, suddenly some or all of the missing items appear again.

To Reproduce Steps to reproduce the behavior:

  1. Open pksm and load a gen4 save file
  2. Select the bag option in the menu
  3. Go to the item list, tap at one item and change it to "(None)" (thus deleting the item)
  4. Save the game
  5. Several items should vanish from the particular section (ie. Poké Balls) of the bag (both in pksm and ingame)
  6. Readd an item by selecting the bag option again, scroll down the list and change the "(None)" entry to any other item
  7. One or more items should reappear again. If not, go back to the menu and select "Bag" again

Expected behavior If deleting an item by changing it to "(None)", it should delete the item and only this item. All the other items will move up a slot, but will not be tempered otherwise.

Information about your environment

  • OS version: 11.17.0.0-50E
  • PKSM version: 10.0.0-2b194722
  • Entrypoint: ???

Additional context I don't know the official english terms of pksm since I'm using the german translation. I'm also not 100% sure if you're supposed to change an item to "(None)" in order to delete it. Might be a dirty way and pksm doesn't like that at all.

Diverscope avatar Aug 19 '23 00:08 Diverscope

Ran into a similar related issue so I decided to add some relevant context

Describe the bug When editing the bag in any gen (currently tested with Black 2 and Omega ruby but I assume this will also presist through other games) setting a slot other than the last one shown on the list to "none" will remove all following items from the list rendering them inaccessible from PKSM until the file is reloaded. This does not seem to affect the bag in game (other than obviously removing said modified item). Changing the item you just set to "none" back into any item will only make the very next item on the list reappear instead of the rest of the list.

To Reproduce Steps to reproduce the behavior:

  1. Open pksm and load any save file
  2. Select the bag option in the menu
  3. Change change any item, excluding the last one on any given list to "none"
  4. All subsequent items should disappear from the list
  5. Change the preveously edited item back into any item
  6. The next slot should be restored but no others

Relevant Screenshots mrg_2024-12-04_11-54-14 288 Before any issues occur

mrg_2024-12-04_11-54-57 596 Edit any item that is not the last one the list and set to "none"

mrg_2024-12-04_11-55-11 406 All subsequent items disappear (in this case the PokeBall in the last slot)

mrg_2024-12-04_11-55-32 295 Edit the same item slot to be an item again

mrg_2024-12-04_11-55-40 861 The pokeball in the following slot is restored but the "none" slot at the end of the list is not (as well as any other items that you may have past there)

Information about your environment

OS version: Luma3DS v13.2.1 PKSM version: v10.1.1-aca22663 Entrypoint: ???

BuffYoda21 avatar Dec 04 '24 20:12 BuffYoda21

There probably isn't an easy way to fix this other than just outright preventing people from setting a item to none. You are moving where the end of the list is, its going to play havoc with anything that comes after the new "end"

Masamune3210 avatar Dec 05 '24 01:12 Masamune3210

No way to detect when the user sets the item to “none” and automatically shift the rest of the list up?

BuffYoda21 avatar Dec 05 '24 02:12 BuffYoda21