Matt Walker comments

Results 40 comments of


                                            Matt Walker

o1vm/pickles: Add the verifier

Need some help testing this. It compiles now, but I'm pretty sure I forgot stuff and it's not correct.

o1vm/pickles: Add the verifier

Ready for final review.

o1vm/pickles: Add the verifier

Note to future viewers of this commit: Consider my commits verified; marc rebased our changes and that's why they aren't signed anymore.

o1vm/pickles: Add the verifier

@dannywillems Let me know if you want more changes or can approve. Should be good, pending CI now.

Fix use-after-free from JavaScript

More background. > The Original Problem > > The original lagrange_commitments_whole_domain_read_from_ptr function had > a use-after-free vulnerability: > > // Original buggy implementation > pub unsafe fn lagrange_commitments_whole_domain_read_from_ptr( > ptr:...

kimchi: Improve memory usage and parallelism of `expr.evaluations`

Just gonna fix up CI.

kimchi: Improve memory usage and parallelism of `expr.evaluations`

The most recent commit removed the tests, since it was now checking that `x==x`, essentially.

Create CLAUDE.md

I will run /init and see what it says.

Create CLAUDE.md

[CLAUDE.md](https://github.com/user-attachments/files/21106354/CLAUDE.md) This is what it generated for me. I ran it twice, since the first time it picked up some spurious info. I haven't checked it for accuracy.

[o1vm] Ensure the instruction passed into the interpreter is the one pointed to by the IP

Hi there! I'm currently working on this issue, sorry! This issue is part of the as-yet-unfinished o1vm work that we are doing, so I think it would be difficult to...