Nick Mills-Barrett

Results 218 comments of Nick Mills-Barrett

> Multiple code paths for different hosts: It does no matter what deploy.py contains for different hosts, the execution is totally independent on every hosts. > Operation order is correct...

I can absolutely say pyinfra works incredibly well for the ES use case, it's one of the places it was first used at scale within a company environment to manage...

So flake8 doesn't do type checking which has prevented this being an issue before! There's currently a PR/branch (https://github.com/Fizzadar/pyinfra/pull/472) tracking implementation of type checking using mypy. The operation functions are...

Hm. I can't replicate this (the error) with either `mypy` or `pylint`; using the following example: ```py from typing import Generator, List from pyinfra.api.operation import operation @operation def shell(commands: List[str])...

This should now be resolved, first by #817 and now by the fantastic #891.

OK this should now properly work everywhere in v2.5 by always using ISO format (https://github.com/Fizzadar/pyinfra/commit/3e0c2b9bb9e5621d473d094422c20c644a6f727f).

I'm not sure this is the right approach for `_ignore_errors` which specifically ignores operation errors, rather than individual commands. Changing this behaviour to continue executing commands after a failure could...

> I might prefer to have some more fine grained function to handle users. The current one is doing too much, but creating a user and managing authorized_keys are independent...

Have implemented the user keys operation here: https://github.com/Fizzadar/pyinfra/commit/1e3e5b4b8ec33d20dca14eb0deb0cf0f71e87cd7, and also added continue on error support in https://github.com/Fizzadar/pyinfra/commit/911594ba77ca34de38971f699eecd4b091cf1430.