Nick Mills-Barrett

Results 218 comments of Nick Mills-Barrett

@4mig4 is this GitHub specific? I've never seen this work before - tested just now in MacDown and it's behaving as Luapress does... Either way while I would like to...

Thank you for raising this @Renerick! I think the updated askpass handling from #852 should indeed respect the temp dir config.

Thank you for splitting this out @lowercase00! Pushed a few bits and a workflow change so we can start iterating on the mypy warnings. I'm keen to get this merged...

> @Fizzadar sorry the delay! Sure, just to make sure I understood correctly, should we add `Any` anywhere Mypy shows warnings to merge asap (making sure there are no mypy...

> In the future, if we are working on a branch with MyPy on, it will be inevitable to fix a couple of things here and there (and this would...

Leaning towards 1 I think. Agree that none of the options are ideal, so suggest we go with 1 and then iterate on fixing up the warnings ASAP. At least...

Found a bit of time to sink into this! Have now fixed all the mypy errors, I attempted to add types where possible. There are a few ignore statements in...

@simon04 that change looks fantastic, I'm about to merge this in if you wouldn't mind PR'ing that against `2.x` that would be amazing!

100% agree, definitely a challenge worth persuing!

Interesting - looks like the result of the upload function was a success despite the error! Thank you for raising this I’ll get a repro working and fix.