Firstyear
Firstyear
@micolous If you have some item to review as well, that'd be great.
Its okay, that's what the checks are for. You've done pretty well for a first time :)
> Please let me know if there's anything else I should do. Thanks. @micolous has just been really busy is all :) I'll ask him again to have a look.
Oh I'm so sorry this fell by the wayside!
I restarted the CI to check :)
@arthurgleckler This has now been released on crates.io. Thank you!
We store them as base64 on the server side, so that they are more compact in *json* dumps. We could probably change it from deserialize_any though to improve this -...
There actually is a way to access the internals, there is a feature called "danger passkey internals" I think. But I don't recommend it for obvious reasons. Messing with the...
@smessmer @micolous and I had a big talk about it yesterday evening and we do agree we should move away from base64urlsafe through out the codebase, but it will take...
> > The PR attached by @Firstyear, doing it by using a feature, seems fragile. > > Yup, I agree. But at least now we know what *not* to do...