intellij-pdf-viewer icon indicating copy to clipboard operation
intellij-pdf-viewer copied to clipboard

Published 20 hours ago • verified publisher icon FirstTimeInForever

Bump pdfjs-dist from 2.6.347 to 4.2.67 in /web-view/bootstrap

Open dependabot[bot] opened this issue 1 year ago • 1 comments
trafficstars

Bumps pdfjs-dist from 2.6.347 to 4.2.67.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the Security Alerts page.

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

dependabot[bot] avatar May 07 '24 11:05 dependabot[bot]

pdfjs has removed the lib directory from pdfjs-dist, so this breaks our imports (https://github.com/mozilla/pdf.js/pull/16350), I'll have a look to see if I can fix that. Not sure where to import BaseReferences from, for example.

PHPirates avatar May 20 '24 06:05 PHPirates

@PHPirates There are two options:

  1. make intellij-pdf-viewer build with the source of pdf.js, this is the way in https://github.com/FirstTimeInForever/intellij-pdf-viewer/pull/114 (However, it mock PDFJSDev in webpack, then requires a production not development)
  2. build a lib version of pdf.js, then make intellij-pdf-viewer build with the lib version. This was the way, however, pdfjs-dist don't ship pdfjs-dist/lib since https://github.com/mozilla/pdf.js/commit/62a9435190463cc3c78f63aec810c330db92a715, which just remove "lib" from "dist" (depends "dist-pre") tasks. However, build the source of pdf.js is too heavily, and as we don't use in LIB way, then we should avoid, just like mozilla says.

liudongmiao avatar Sep 15 '24 13:09 liudongmiao

@liudongmiao Clear, thanks! Then let's close this pull request and continue in #114

PHPirates avatar Sep 15 '24 18:09 PHPirates

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot[bot] avatar Sep 15 '24 18:09 dependabot[bot]