Simon Erkelens comments

Results 81 comments of


                                            Simon Erkelens

This breaks on PHP

It threw me errors on 7.4... ;) Not sure why either, but /shrug, if it stops complaining, I'm fine

LGTM. I know the tests are currently not functional, but could you have a look at those anyway, to ensure that they match the new spec?

Well, besides your typo... That is actually a pretty good idea to add the common static methods to the docblock

Any news on this?

Tagging @tractorcow @unclecheese

I might have a look somewhere this weekend... but no promises...

Converted PR to a Draft, so it won't accidentally be merged :)

I think, the tests wouldn't fail on MySQL, if the circleci config was changed to `dist-upgrade` instead of `upgrade`

Don't worry too much about the static access errors, I happily ignore those ;)