firely-net-sdk icon indicating copy to clipboard operation
firely-net-sdk copied to clipboard

Snapshot does not including base bindings.

Open MatthijsvdWielen opened this issue 4 years ago • 1 comments

Hi,

We've encountered a subtle issue where Forge and Simplifier don't seem to play nice together (FHIR STU3). When we add the "11179-permitted-value-conceptmap"-extension to a binding in a profile, but don't alter the ValueSet that's being bound, Forge doesn't include the reference to the ValueSet in the differential. This seems fine since it's the same as the base from where the profile was derived from.

However, when generating the snapshot the base bindings are not added even though they should be.

For example, take the following snippet from our zib-AllergyIntolerance profile (https://simplifier.net/nictizstu3-zib2017/zib-allergyintolerance):

<binding>
<strength value="required" />
<valueSetReference>
<extension url="http://hl7.org/fhir/StructureDefinition/11179-permitted-value-conceptmap">
<valueReference>
<reference value="http://nictiz.nl/fhir/ConceptMap/AllergieStatusCodelijst-to-allergy-status" />
<display value="AllergieStatusCodelijst-to-allergy-status" />
</valueReference>
</extension>
<reference value="http://hl7.org/fhir/ValueSet/allergy-clinical-status"/>
</valueSetReference>
</binding>

Opening and saving this profile in Forge would remove the reference element from the differential as the "allergy-clinical-status" ValueSet is the same as in the core AllergyIntolerance resource.

MatthijsvdWielen avatar Aug 25 '21 08:08 MatthijsvdWielen

I think this is a duplicate of #1516. This has been fixed (it was a Firely Favorite) in the January 2021 release. Luckily, @mharthoorn is currently busy updating Simplifier to be able to use a newer version of the SDK.

ewoutkramer avatar Aug 25 '21 12:08 ewoutkramer

Assume this has been fixed

mmsmits avatar May 01 '24 13:05 mmsmits