firely-net-sdk icon indicating copy to clipboard operation
firely-net-sdk copied to clipboard

[Validator]: Should the validator throw errors for non-allowed constraints?

Open mmsmits opened this issue 5 years ago • 2 comments

Example: In a StructureDefinition, we change Patient.id from 0..1 to 124..127. This is obviously incorrect and not allowed to make this constraint (because it isn't a constraint). However our validator doesn't go as deep as to mark these things as errors.

Should it? Here is an example of some of these errors that are still allowed by the validator.

https://staging.simplifier.net/GoldonGit/MyPatient/~overview

Also attached if staging is down.

sd-validation.txt

mmsmits avatar Feb 13 '20 10:02 mmsmits

Related to #856

cknaap avatar Feb 13 '20 13:02 cknaap

Yes, I consider this an example of what #856 is about.

ewoutkramer avatar Sep 10 '20 14:09 ewoutkramer