HeaderEditor icon indicating copy to clipboard operation
HeaderEditor copied to clipboard

Make HeaderEditor start early on Firefox

Open sebast889 opened this issue 6 years ago • 3 comments

There is a API to do this on Firefox. Please make a way to make HeaderEditor start early on Firefox so that when Firefox is booted up or pages are restored from session any requests HeaderEditor changes/sends/modifies actually take effect on those pages. This is important so no header edits get bypassed.

From reading about this elsewhere webRequest listener has to registered in a certain way for this to happen. More Information on how to start early: https://bugzilla.mozilla.org/show_bug.cgi?id=1447551 https://bugzilla.mozilla.org/show_bug.cgi?id=1503721

sebast889 avatar Jan 04 '19 16:01 sebast889

I don't know is webRequest a persistent event or not, but even if it is, HE still require reading rules from database when starting up. It may take a few seconds or longer (depend on how many rules user have). If all requests are blocking in this time, user's browsing experience will be bad. I think HE can provide some extra features to make browsing experience better, but it should not make the basic experience worse.

sylingd avatar Jan 04 '19 17:01 sylingd

I don't think it will make the browsing experience worse because it will mainly affect the first 0.1-10 seconds on startup only. Blocking longer than that I think would be rare occurrence. In my opinion the benefit outweighs the negative (where session pages restored on startup could bypass HE rules or the user will browse thinking HE is working but it isn't).

sebast889 avatar Jan 04 '19 18:01 sebast889

@sylingd If it can help convince you, uBlock Origin has this implemented for the Firefox version and so far I haven't seen anyone complain that it is making browsing experience worse. If an extension like that with millions of users and a lot of rules handling hasn't seen any negative effects I think HE won't see any either :)

sebast889 avatar Feb 02 '19 19:02 sebast889