firebird icon indicating copy to clipboard operation
firebird copied to clipboard

Postfixes for PR#8145

Open aafemt opened this issue 7 months ago • 3 comments

aafemt avatar May 20 '25 12:05 aafemt

Commit "Return isc_dsql_error prefix" has been undone because it caused more problems than solved.

aafemt avatar May 23 '25 11:05 aafemt

@dyemanov @hvlad Can one on you review and merge this?

mrotteveel avatar Jun 14 '25 10:06 mrotteveel

@asfernandes Do you have a testcase that fail on this build?

aafemt avatar Jun 17 '25 11:06 aafemt

Just one question: are your changes really needed for VARCHAR parameters?

dyemanov avatar Jul 04 '25 08:07 dyemanov

IMHO, yes. Some libraries do with them the same as with CHAR: overrun maximum length in characters as derived from maximum length in bytes while still fit to the storage. Besides, it suits to the standard's requirement to silently cut trailing blanks if they don't fit on store. Lastly it may help with API backward compatibility if longer VARCHARs are ever allowed.

aafemt avatar Jul 04 '25 08:07 aafemt