firebird icon indicating copy to clipboard operation
firebird copied to clipboard

Ability to create an inactive index

Open aafemt opened this issue 1 year ago • 1 comments

Implementation of #8090.

aafemt avatar Apr 20 '24 15:04 aafemt

This PR also solves #6233.

aafemt avatar Jul 10 '24 12:07 aafemt

Unless there are objections, I will merge this PR tomorrow.

dyemanov avatar Oct 24 '24 12:10 dyemanov

I would understand if you assigned to me the mentioned issues, but what is the point to assign a pull request? There is nothing I can do with it in absence of write rights for repository.

aafemt avatar Oct 24 '24 12:10 aafemt

This is for documentation purposes (release notes). I prefer to have an explicit assignee everywhere, just for clarity. I've also assigned you to #8090 but cannot do the same for #6233 as non-members can be assigned to an issue only if they commented inside the ticket.

dyemanov avatar Oct 24 '24 12:10 dyemanov

On 10/25/24 16:01, Vlad Khorsun wrote:

@.**** commented on this pull request.


In src/dsql/DdlNodes.h https://github.com/FirebirdSQL/firebird/pull/8091#discussion_r1816644225:

@@ -1790,6 +1790,7 @@ class CreateIndexNode : public DdlNode MetaName name; bool unique; bool descending;

  • bool active;

Funny (not). You should learn and follow basic rules before attempt to contribute something.

Dmitry, sorry, but +1.

AlexPeshkoff avatar Oct 25 '24 16:10 AlexPeshkoff

This class currently has nine members, seven are initialized by explicit constructor, one by implicit constructor and one in the code immediately after instantiation. What exactly do you expect me to do with this mess?

aafemt avatar Oct 25 '24 16:10 aafemt