firebird icon indicating copy to clipboard operation
firebird copied to clipboard

Raised API version because of changes related to #6886

Open aafemt opened this issue 3 years ago • 4 comments

aafemt avatar Sep 16 '21 15:09 aafemt

Dmitry & Vlad! I'm not sure - is it correct reason to change FB_API_VER ?

AlexPeshkoff avatar Sep 16 '21 15:09 AlexPeshkoff

I would use it like this:

void ODBCAttachment::detach(Firebird::CheckStatusWrapper* status)
{
    internalDetach(status);
#if FB_API_VER > 40
   release();
#endif
}
#if FB_API_VER > 40
void ODBCAttachment::deprecatedDetach(Firebird::CheckStatusWrapper* status)
{
    internalDetach(status);
}
#endif

aafemt avatar Sep 19 '21 10:09 aafemt

We can also make cloop generate per-interface #define version, instead of only C++ const.

asfernandes avatar Sep 19 '21 13:09 asfernandes

Generating preprocessor constant together with C++ one seems logical. At least much better than artificial FB_API_VER.

AlexPeshkoff avatar Sep 20 '21 15:09 AlexPeshkoff