reactfire icon indicating copy to clipboard operation
reactfire copied to clipboard

updating docs from 'useSignInCheck' to 'useSigninCheck'

Open thomasmburke opened this issue 3 years ago • 1 comments

Ran into import errors when following the docs because of this subtle lowercase i.

I think overall it would be worth having this camel case exception be consistent with signInCheckResult, but not worth introducing a breaking change in my opinion, so just looking to update the docs and references in this repo.

thomasmburke avatar Feb 05 '22 23:02 thomasmburke

Thanks @thomasmburke!

jhuleatt avatar May 16 '22 21:05 jhuleatt

fixed in this commit: https://github.com/FirebaseExtended/reactfire/commit/414201e88bd6f6701998993f6203e4d49773147b

jhuleatt avatar Aug 17 '22 18:08 jhuleatt

Sorry for missing this!

thomasmburke avatar Aug 17 '22 20:08 thomasmburke