polymerfire icon indicating copy to clipboard operation
polymerfire copied to clipboard

Missing comments for some firebase-document attributes/methods

Open phidias51 opened this issue 9 years ago • 1 comments

Missing comments for the following firebase-document attributes:

  • isNew
  • app
  • appName
  • db
  • ref
  • path (the description says "N.B. path is case sensitive" but doesn't explain what 'N.B.' means", abbreviations should be spelled out before use)
  • zeroValue

Comments should also indicate which attributes are required.

The following methods & method parameter comments are missing:

  • destroy()
  • getStoredValue(path)
  • memoryPathToStoragePath(path)
  • reset()
  • setStoredValue(path, value)
  • storagePathToMemoryPath(storagePath)

phidias51 avatar Nov 26 '16 15:11 phidias51

isNew & zeroValue r getter so zeroValue can't set

hedcet avatar Dec 11 '16 06:12 hedcet