firepad icon indicating copy to clipboard operation
firepad copied to clipboard

Dead key breaks font settings in Firefox with CodeMirror

Open marinabilles opened this issue 9 years ago • 3 comments

Version info

Firebase: 3.3.0

Firepad: 1.4.0

CodeMirror: 5.18.2

Other (e.g. Node, browser, operating system) (if applicable): Firefox 48.0, Linux (buggy) and Chromium 51.0, Linux (works)

Test case

Set up Firepad with CodeMirror with everything being default (i.e. this demo)

Steps to reproduce

Choose a keyboard layout with dead keys, e.g. the German keyboard layout (de_DE) that uses the ´ (accute accent) key (equivalent to the = (equals) key on the English keyboard) as a dead key for typing letters like á.

Select a line, change the font settings (change font size, color, font face, bold, etc.) and start typing. Then type the dead key ´ and a following letter to produce an accented character like á.

Expected behavior

Letter á gets added to the text box while preserving the font settings (works in Chromium)

Actual behavior

Letter á gets added, but all font settings are reset (font size, color, font face, bold, etc.) (this happens only in Firefox) Note: this behavior does not appear in the vanilla CodeMirror using Firefox. Only Firepad is affected.

firepad-bug

marinabilles avatar Sep 02 '16 09:09 marinabilles

Strange. Can you try it on the examples at https://firepad.io/examples/#-tYr7LEFcgf ? demo.firepad.io is on a slightly older version of CodeMirror. I'm also curious if the problem happens in both the code editor example and the rich-text example...

mikelehen avatar Sep 02 '16 14:09 mikelehen

I tried it with the current version of firepad from the CDN as well as with the demo.firepad.io.

On https://firepad.io/examples/#-tYr7LEFcgf :

  • Rich text: the error appears
  • Code Editing: no error
  • Ace: no error.

marinabilles avatar Sep 02 '16 15:09 marinabilles

Cool. Thanks for confirming.

FYI- I don't have a ton of time for digging into bugs right now, but welcome pull requests if somebody has cycles to track this down. :-)

mikelehen avatar Sep 02 '16 15:09 mikelehen