emberfire icon indicating copy to clipboard operation
emberfire copied to clipboard

Type Error: firebase-app.ts

Open Alonski opened this issue 5 years ago • 2 comments

Version info

e.g.
DEBUG: -------------------------------
DEBUG: Ember      : 3.16.0
DEBUG: Ember Data : 3.17.0
DEBUG: Firebase   : 7.7.0
DEBUG: EmberFire  : 3.0.0-rc.6
DEBUG: jQuery     : 0
DEBUG: -------------------------------

Test case

Steps to reproduce

  1. Install this addon in a new Ember Octane + Typescript app.
  2. Run Ember Serve/Builder and receive an error.

Expected behavior

No type error is thrown.

Actual behavior

This type error is thrown:

../../node_modules/emberfire/services/firebase-app.d.ts:14:5 - error TS2416: Property 'name' in type 'FirebaseAppService' is not assignable to the same property in base type '{ name: undefined; firebase: ComputedProperty<FirebaseService, FirebaseService>; } & Service & { name: undefined; firebase: ComputedProperty<...>; }'.
  Type 'string | undefined' is not assignable to type 'undefined'.
    Type 'string' is not assignable to type 'undefined'.

14     name?: string;

Alonski avatar Mar 14 '20 09:03 Alonski

@jamesdaniels Any ideas :)

Alonski avatar Mar 18 '20 20:03 Alonski

Would this fix things?

declare const FirebaseAppService_base: Readonly<typeof Service> & (new (properties?: object | undefined) => {
    name?: string;
    firebase: import("@ember/object/computed").default<FirebaseService, FirebaseService>;
} & Service) & (new (...args: any[]) => {
    name?: string;
    firebase: import("@ember/object/computed").default<FirebaseService, FirebaseService>;
} & Service);

Alonski avatar Mar 18 '20 20:03 Alonski