emberfire
emberfire copied to clipboard
Type Error: firebase-app.ts
Version info
e.g.
DEBUG: -------------------------------
DEBUG: Ember : 3.16.0
DEBUG: Ember Data : 3.17.0
DEBUG: Firebase : 7.7.0
DEBUG: EmberFire : 3.0.0-rc.6
DEBUG: jQuery : 0
DEBUG: -------------------------------
Test case
Steps to reproduce
- Install this addon in a new Ember Octane + Typescript app.
- Run Ember Serve/Builder and receive an error.
Expected behavior
No type error is thrown.
Actual behavior
This type error is thrown:
../../node_modules/emberfire/services/firebase-app.d.ts:14:5 - error TS2416: Property 'name' in type 'FirebaseAppService' is not assignable to the same property in base type '{ name: undefined; firebase: ComputedProperty<FirebaseService, FirebaseService>; } & Service & { name: undefined; firebase: ComputedProperty<...>; }'.
Type 'string | undefined' is not assignable to type 'undefined'.
Type 'string' is not assignable to type 'undefined'.
14 name?: string;
@jamesdaniels Any ideas :)
Would this fix things?
declare const FirebaseAppService_base: Readonly<typeof Service> & (new (properties?: object | undefined) => {
name?: string;
firebase: import("@ember/object/computed").default<FirebaseService, FirebaseService>;
} & Service) & (new (...args: any[]) => {
name?: string;
firebase: import("@ember/object/computed").default<FirebaseService, FirebaseService>;
} & Service);