[BUG] channelId can't be blank

[wneel]

Action config

Env: node: v18.20.5 npm: 10.8.2 firebase-tools: 13.29.1

uses: FirebaseExtended/action-hosting-deploy@v0
        with:
          repoToken: ${{ secrets.GITHUB_TOKEN }}
          firebaseServiceAccount: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_XXX }}
          projectId: xxx
          firebaseToolsVersion: "13.29.1"
          channelId:
          # same issue with "channelId" blank or without
        env:
          FIREBASE_CLI_EXPERIMENTS: webframeworks
          FIREBASE_FRAMEWORKS_BUILD_TARGET: production

Error message

[command]/opt/hostedtoolcache/node/18.20.5/x64/bin/npx [email protected] hosting:channel:deploy  --expires 7d --project xxx --json
{
  "status": "error",
  "error": "channelID is currently required"
}{
  "status": "error",
  "error": "channelID is currently required"
}
The process '/opt/hostedtoolcache/node/18.20.5/x64/bin/npx' failed with exit code 1

Expected behavior

According to the README the channelId can be manually set to live or leaved blank or "will be auto-generated per branch or PR".

When leaved blank no error should occur.

Actual behavior

Currently, in my case no channelID is generated and this line is being triggerd.

[yoannes]

Same here

[rcleveng]

I'm getting this error trying to deploy from github actions now.

I followed the quickstart instructions on getting started (https://console.firebase.google.com/project/${PROJECT_NAME}/overview) for my new project.

using the command firebase init automatically created the github actions workflow for me which no longer works.

The documentation here in this repo, explicitly points out that the channelId is recommended to be blank (reference here: https://github.com/FirebaseExtended/action-hosting-deploy/blob/main/README.md?plain=1#L125)

There doesn't seem to be any recent changes since May 2024, there had to be some change somehwere else in the tooling it seems which broke the happy path here

[wneel]

Hi, take a look at the extra error handling I did here https://github.com/FirebaseExtended/action-hosting-deploy/pull/405, I guess this come from the github action not being able to get the current branch informations, btw I hope someone from the team can reply us

[arcane-p]

This is still ongoing. It is a shame both the documentation and the default generated files actively mislead the users as to what functionality can be expected