action-hosting-deploy icon indicating copy to clipboard operation
action-hosting-deploy copied to clipboard

Published 20 hours ago • verified publisher icon FirebaseExtended

upgrades the runtime to node20, now that 16 is EoL

Open bkendall opened this issue 1 year ago • 1 comments

bkendall avatar Feb 21 '24 20:02 bkendall

Visit the preview URL for this PR (updated for commit bbc39f0):

https://action-hosting-deploy-demo--pr344-bk-node20-mw7qfbq4.web.app

(expires Wed, 06 Mar 2024 20:40:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ca07ce2c831b1990b78fcf2ecdfe230a486dc973

github-actions[bot] avatar Feb 21 '24 20:02 github-actions[bot]

@bkendall @jhuleatt Can this pull request be merged and released? You can solve the following issues. #341

testak-m avatar Mar 09 '24 09:03 testak-m

@bkendall @jhuleatt Is there anything else we need to merge this PR?

sam-golioth avatar Mar 15 '24 20:03 sam-golioth

@bkendall any chance you'll merge this soon?

huggsboson avatar Mar 20 '24 06:03 huggsboson

@bkendall @jhuleatt ping

testak-m avatar Mar 24 '24 17:03 testak-m

Will someone have a look, because due to the EoL we have builds failing.

thomasvht avatar Mar 26 '24 12:03 thomasvht

@inlined Is it possible to merge this pull request? This action is used in firebase-tools.

testak-m avatar Mar 29 '24 05:03 testak-m

@henrylangenhoven I see the changes are approved which is great. Is there someone who can merge the change? 😄

thomasvht avatar Apr 10 '24 08:04 thomasvht

@developit hello! I found your name in the author field. https://github.com/FirebaseExtended/action-hosting-deploy/blob/120e124148ab7016bec2374e5050f15051255ba2/action.yml#L17

I have a request for you, the author. Could you please merge and release this pull request? please!

testak-m avatar Apr 11 '24 17:04 testak-m

I don't have merge rights on this repo, sorry.

developit avatar Apr 11 '24 17:04 developit

@developit I understand your position. Thank you for checking.

testak-m avatar Apr 13 '24 15:04 testak-m

@jhuleatt Are you still busy? Don't have time to merge and release this pull request?

testak-m avatar Apr 13 '24 15:04 testak-m

@jhuleatt Are you still busy? Don't have time to merge and release this pull request?

cc @jhuleatt

EricCheungAO avatar Apr 14 '24 06:04 EricCheungAO

He seems to be active. https://github.com/FirebaseExtended/firebase-framework-tools/pull/161

I was relieved to know that he was alive.

testak-m avatar Apr 14 '24 14:04 testak-m

Does anyone know what version this is. The CLI is still generating FirebaseExtended/action-hosting-deploy@v0, is the updated one v1? (and has it been released to Github)

lesv avatar Apr 17 '24 04:04 lesv

@lesv It seems that it has been merged but not released. https://github.com/FirebaseExtended/action-hosting-deploy/releases

It has not been released and cannot be used in any version. v0 refers to v0.7.1.

testak-m avatar Apr 17 '24 16:04 testak-m

@jhuleatt Can you release it?

testak-m avatar Apr 17 '24 16:04 testak-m

@jamesdaniels @leoortizz @Yuangwang @sjjj986 @bkendall He seems busy. Can you guys help him make the release?

testak-m avatar Apr 17 '24 17:04 testak-m

I submitted a pull request to firebase-tools to specify the version by hash value. The warning should disappear once released. https://github.com/firebase/firebase-tools/pull/7025

178inaba avatar Apr 21 '24 17:04 178inaba