action-hosting-deploy Node.js 16 actions are deprecated

Node.js 16 actions are deprecated

Open rohit231095 opened this issue 5 months ago • 16 comments

I am seeing this below warning in my project's GitHub actions repeatedly. This Firebase deployment action needs an upgrade to Node.js 18 or 20 as version 16 actions are deprecated.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: FirebaseExtended/action-hosting-deploy@v0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Please upgrade this action as soon as possible.

Jan 31 '24 00:01 rohit231095

@rohit231095 do you have only the warning in the console or the action is broken as well?

Jan 31 '24 11:01 MNITD

@MNITD I can see only a warning like the image below. The action is still working, and deployment is not broken.

Reporting it to prevent any incoming breaking possibilities later on.

Jan 31 '24 13:01 rohit231095

I have already submitted PR #340 to address this.

Would be good if some of the maintainers could follow up before Node 16 is sunset!

Feb 02 '24 14:02 oyvindwe

Actions are now failing:

That is most likely some other problem with your job. Sunset date for node 16 has not yet been communicated.

Feb 09 '24 16:02 oyvindwe

Actions are now failing:

That is most likely some other problem with your job. Sunset date for node 16 has not yet been communicated.

You are right - please accept my apologies!

Feb 10 '24 07:02 annoyingmouse

FYI, while maintainers don't merge @oyvindwe's PR #340 that fixes this warning, you can edit your action usage to point to the PR's commit directly:

-FirebaseExtended/action-hosting-deploy@v0
+FirebaseExtended/action-hosting-deploy@79b1a830a9ae85409cb38056dd7761f6f1cb83fd

Feb 19 '24 12:02 filfreire

This workaround to set a node version doesn't work:

      - uses: actions/setup-node@v4
        with:
          node-version: '18'

When using FirebaseExtended/action-hosting-deploy@v0 I still get this warning:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: FirebaseExtended/action-hosting-deploy@v0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Mar 08 '24 00:03 johnnyoshika

This appears to have now been enforced, making this action no longer usable.

The only way I could get it to work was by using @filfreire 's solution above. Is it possible to get PR #340 merged?

Mar 08 '24 02:03 steve-scorn

@johnnyoshika

This workaround to set a node version doesn't work:

This is to set the node version your build uses, not the version used by the action itself.

@steve-scorn:

This appears to have now been enforced, making this action no longer usable.

For now, you can work around this issue by setting the environment variabel ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true, but that will stop working May 13. See https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Mar 08 '24 07:03 oyvindwe

I asked if it would be possible to release #344 since it would be resolved once it was released. https://github.com/FirebaseExtended/action-hosting-deploy/pull/344#issuecomment-1986804951