action-hosting-deploy icon indicating copy to clipboard operation
action-hosting-deploy copied to clipboard

[BUG] GitHub comment not appearing

Open kasvith opened this issue 1 year ago • 2 comments

Action config

      - uses: FirebaseExtended/action-hosting-deploy@v0
        with:
          repoToken: '${{ secrets.GITHUB_TOKEN }}'
          firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT }}'
          channelId: preview
          projectId: appname

Error message

No Errors

Expected behavior

GithHub comment to be appear in PR

Actual behavior

No comments appearing in PR. But we get the deploy URL in the deploy log

kasvith avatar Jun 29 '23 09:06 kasvith

I think I'm running into the same issue - are you seeing

Deploying to Firebase Preview Channel <channel name> 
Commenting on PR

in your build logs, or just the Deploying... line?

Can I ask what your trigger is for your GitHub Action? (push to branch, PR created, etc etc)

seth-acuitymd avatar Nov 17 '23 00:11 seth-acuitymd

I thought I had the same issue, but then I realised that it will only comment once, meaning even if you deploy again it won't add a new comment. This could be made clearer in the docs

mpuxted avatar Feb 12 '24 16:02 mpuxted