action-hosting-deploy icon indicating copy to clipboard operation
action-hosting-deploy copied to clipboard

[BUG] Cannot Find Module "is-npm"

Open brian-cresicor opened this issue 3 years ago • 8 comments
trafficstars

Action config

Error message

image

Expected behavior

Deployment completes successfully.

Actual behavior

Deployment fails due to missing module is-npm in firebase-tools.

brian-cresicor avatar Sep 23 '22 08:09 brian-cresicor

+1

vigneshwaran-vtpl avatar Sep 23 '22 09:09 vigneshwaran-vtpl

Same here :/

UgniusSmidtas avatar Sep 23 '22 10:09 UgniusSmidtas

+1

emrahyumuk avatar Sep 23 '22 11:09 emrahyumuk

This error comes from the firebase/firebase-tools dependency. I think that will be solved on a future update on their end https://github.com/firebase/firebase-tools/issues/5010

ocruzv avatar Sep 23 '22 11:09 ocruzv

This error comes from the firebase/firebase-tools dependency. I think that will be solved on a future update on their end firebase/firebase-tools#5010

There is no problem with firebase-tools on local. I just get this error on github action. the action make deployment successfully but get this error.

emrahyumuk avatar Sep 23 '22 11:09 emrahyumuk

Same here. How could this start happening with no code changes or dep changes? Is there some funny config somewhere? I can see is-npm in my package lock file. - we are on firebase-tools version 10.7.0. Updating that didn't help.

aliak00 avatar Sep 23 '22 12:09 aliak00

I have the same issue, updated everything in my project but it didn't help

Maria-Lurdes avatar Sep 23 '22 17:09 Maria-Lurdes

Thanks for reporting. We've got a couple people looking into this trying to figure out what happened. So far as we can tell, locally deploying should work fine and it's just the GH action that's broken (which is only more confusing).

bkendall avatar Sep 23 '22 17:09 bkendall

FYI @bkendall : Changed github action to use node 16 instead of 14 and it all good 🤷

image

aliak00 avatar Sep 24 '22 11:09 aliak00

+1

gorden0929 avatar Sep 26 '22 01:09 gorden0929

Same here

elmehdibm avatar Sep 26 '22 06:09 elmehdibm

+1

Jerkovic avatar Sep 26 '22 07:09 Jerkovic

+1

dexterastin avatar Sep 26 '22 09:09 dexterastin

+1

igorgottschalg avatar Sep 26 '22 17:09 igorgottschalg

+1

olbapd avatar Sep 26 '22 19:09 olbapd

Alright, we've at least made a little patch in the code we think is triggering the error to catch it and be a little more quiet if this happens. We're still digging into why this is happening, but planning on releasing tomorrow morning with that patch.

bkendall avatar Sep 27 '22 00:09 bkendall

This is the patch we made, fwiw: firebase/firebase-tools#5010

bkendall avatar Sep 27 '22 00:09 bkendall

+1 👍🏽

dawogfather avatar Sep 27 '22 00:09 dawogfather

+1

AntiraLoachote avatar Sep 27 '22 05:09 AntiraLoachote

Working now, thanks!

dcroote avatar Sep 27 '22 20:09 dcroote

It's working now, thank you!

victorwvieira avatar Sep 28 '22 06:09 victorwvieira