bot icon indicating copy to clipboard operation
bot copied to clipboard

[BUG] "Save to Quote" feature does not work for initial forum messages

Open nakoyasha opened this issue 1 year ago • 5 comments

Describe the bug

Saving initial forum messages (aka, the very first message in a forum post) will not work, the bot will claim that it saved the message successfully, but will silently fail upon trying to embed that message.

To Reproduce

  • Make a forum channel
  • Make a post in the forum channel, and use "Save as Quote" on it
  • Try to embed it in a different channel

Expected behavior

For the message to be embedded like any other message

Screenshots

Discord & device versions Canary 311260, Windows 11

Additional context

nakoyasha avatar Jul 19 '24 17:07 nakoyasha

I'm unable to reproduce this issue and can quote saved initial forum messages just fine. Could you try again but when sending the link, change it to debug.discord.com and share a screenshot of what the bot responds with?

GamingGeek avatar Jul 20 '24 10:07 GamingGeek

The bot seems to not reply to the message at all, maybe the link is different enough that it doesn't match anymore?

The link/message I'm trying to embed is https://debug.discord.com/channels/820745488231301210/1263229750655057950/1263229750655057950 (it's from No Text to Speech's discord)

Also, is the bot supposed to embed the message like normal (for messages that I know embed correctly) even when the link's domain is set to debug.discord.com? I might just be a little dum and missing something

nakoyasha avatar Jul 20 '24 13:07 nakoyasha

Some of my friends (who are also able to reproduce this exact same issue) told me that it'd be better if we moved to Discord DMs, would that be okay? (if it is, my user is @nakoyasha)

nakoyasha avatar Jul 20 '24 13:07 nakoyasha

Ah, I've managed to identify the issue. It was never about it being the first message in a forum channel but rather the size of the video in that message.

The maximum size that Fire will reupload is 10mb for non-premium, 25mb for premium and that video is just over 10mb. I tried myself with a 30mb file and encountered the same issue.

It should fallback to the old embed style of quoting in the case of files that are too large for it to reupload so I'll need to look into why it is not doing that

GamingGeek avatar Jul 20 '24 17:07 GamingGeek

That didn't take long at all. It took me testing with my local instance to remember that cross cluster quotes (i.e. quoting from a different cluster since they are different processes) don't currently support the old style and require a webhook

I don't currently know whether or not I'll be able to support the old style nor do I know when I'd be able to add support for it if I can so for now, this is going to be put on hold for me to look at another time since it has become a much larger project than I initially expected

GamingGeek avatar Jul 20 '24 17:07 GamingGeek