UnitedSets icon indicating copy to clipboard operation
UnitedSets copied to clipboard

[Feature Request] - Setting tabs aside

Open Arpolend opened this issue 3 years ago • 12 comments

Would be great to bring back this feature as well. No need to save the current states of apps, just launching them in one window would be enough.

Arpolend avatar Oct 22 '22 16:10 Arpolend

Do you mean set tabs aside feature like Microsoft Edge legacy?

GetGet99 avatar Oct 22 '22 20:10 GetGet99

  • If setting tabs aside means just hiding those tabs temporarily like MSEdge legacy, then it is not very hard to implement.
  • If it requires relaunching apps, or saving and reloading tabs when United Sets is closed, #10 might be needed for this issue. I'm not sure which one you mean. Can you clarify?

GetGet99 avatar Oct 22 '22 20:10 GetGet99

Yes I mean the Edge Legacy feature.

But Edge Legacy didn't hide the tabs, it saved them, you could turn the PC off and still restore them afterwards. There is a faithful copy of this feature as an extension for Chrome, you can check how it works: https://github.com/xfox111/TabsAsideExtension

So the two ways you described are the same. I just propose saving/restoring not only browser tabs but apps as well, i.e. the second option. Maybe even syncing them between devices like the aforementioned extension does.

For example, I create a school project and group a word document, some edge tabs and some unknown app. Then I set it aside for a month, can turn the PC off and etc. After that, pressing restore should open that exact document and those tabs, but for an unknown app it could just reopen it from scratch if saving its state was not possible.

Arpolend avatar Oct 23 '22 08:10 Arpolend

Oh sorry I forget how it works. Thanks for clarification. To make implementation easier, I think I will implement like this.

  • When setting tabs aside, just hide the window and you can get the window back instantly at the state it is in (assuming the app does not do some crazy stuff when it is hidden)
  • if you close United Sets and reopen the next time bringing those tabs back will rerun the apps.

The reason I choose not to close window immedietly is that some apps are going to "hey, do you want to save your work" or something like that preventing closing window to be sucessful.

GetGet99 avatar Oct 23 '22 18:10 GetGet99

Sorry accidentally pressed the button

GetGet99 avatar Oct 23 '22 18:10 GetGet99

Implementation steps

  • [x] Setting tabs aside but does not save the tabs when we close the app
  • [ ] Implement #10
  • [ ] Full setting tabs aside implementation

GetGet99 avatar Oct 23 '22 18:10 GetGet99

That was also a problem in edge legacy, when websites wanted something saved, e.g. inking. Edge just set aside all other tabs and kept these. Not an elegant solution, but there is some logic.

Also a small thing: when setting group aside, it didn't hide the entire window, but left a "start page" tab so that you could easily switch between saved groups.

Arpolend avatar Oct 24 '22 07:10 Arpolend

I would say that the page when the app is opened with no tabs open to be "start page" for United Sets.

GetGet99 avatar Oct 24 '22 09:10 GetGet99

Anyways, we plan to work on #12 first then we might take a look at this afterward. This is because the tab system is going to be changed internally, and the way to store data will also need to be implemented for those changes.

Implementation on #12 is expected to not take more than a week. Note: Even though I overestimated the time needed by a lot, I do not guarantee that statement.

GetGet99 avatar Oct 24 '22 09:10 GetGet99

Good News! I finished implementing the first mockup. This does not save if you close and reopen the app.

https://user-images.githubusercontent.com/41405393/203991698-29857b6a-5738-4612-a1b5-f8a0e058fbc1.mp4

GetGet99 avatar Nov 25 '22 13:11 GetGet99

However, in order for me to continue as I say, I need to implement #10 Therefore, I added "base feature for enhancement needed" tag, meaning that I will continue to implement this after #10 is implemented.

GetGet99 avatar Nov 25 '22 13:11 GetGet99

Could be implemented soon since #47 was merged

GetGet99 avatar May 21 '24 08:05 GetGet99