Fintan Halpenny

Results 111 comments of Fintan Halpenny

Ya, but this still exists in our code today https://github.com/radicle-dev/radicle-link/blob/master/cli/lnk-identities/src/git/checkout.rs#L200-L201 So I think it's actually the `handle` that has a space in it, could you confirm that? Guess I didn't...

> If by handle, you mean the project name, then yes, it's got spaces in it ("Bob Walsh"): I believe it would be a `Person`'s `name` field that is used....

This conversation seems related to https://github.com/radicle-dev/radicle-link/issues/589 and maybe we should try to flesh out a GRAND plan for telemetry and introspection :)

I'm under the impression that the version of `radicle-cli` that uses `linkd` is not going to be officially published, so I don't think it's worth digging into this, personally. If...

Would this essentially look like: ```rust use crate::Cstring; use std::collections::{BTreeMap, BTreeSet}; pub enum Value { Object(BTreeMap), Array(BTreeSet), String(Cstring), Number(Number), Bool(bool), Null, } pub enum Number { U64(u64), I64(i64), } impl...

I narrowed some logs down to the first namespace `hnrkbtw9t1of4ykjy6er4qqwxtc54k9943eto` here [log.txt.gz](https://github.com/radicle-dev/radicle-link/files/7111284/log.txt.gz). When I grep'd `/hnrkbtw9t1of4ykjy6er4qqwxtc54k9943eto.*heads:` the `heads` of the signed refs were always empty. So I think the mystery...

> When I grep'd /hnrkbtw9t1of4ykjy6er4qqwxtc54k9943eto.*heads: the heads of the signed refs were always empty. So I think the mystery here is why those heads never get entered into the signed_refs....

Something I find weird about this log is that a peer keeps advertising the same `Have` repeatedly: ``` 24 Jul 28 10:00:52.008 DEBUG accept{peer_id=hybz9gfgtd9d4pd14a6r66j5hz6f77fed4jdu7pana4fxaxbt369kg}:incoming:incoming{remote_id=hyd7cb39wws6jz5wmifzwtjn8u57siw6knipqttk6nhc657r1fozaw remote_addr=188.120.235.3:12345}:tock{tock=AttemptSend { to: GenericPeerInfo { peer_id:...

> In any case it might help to limit the amount of ingress streams per-peerid, as a mitigation. But radicle-link recently added rate limiting, so this is even _more_ curious...

> Any update on this? This issue often makes Upstream unusable :( I thought the last thing we talked about was Upstream updating `librad` to this commit https://github.com/radicle-dev/radicle-link/commit/cb91ccdd07d08276112c876a670941f9be8f18ef and seeing...