finschia-sdk icon indicating copy to clipboard operation
finschia-sdk copied to clipboard

Why not stop using "oc" and "ostracon" in variable names, function names, etc?

Open ulbqb opened this issue 2 years ago • 2 comments

Summary

I want to stop using "oc" and "ostracon" in variable names, function names, etc.

Problem Definition

By changing "tm" and "tendermint" in the original code to "oc" and "ostracon", a large number of non-important diffs occur, making it difficult to compare important logic with the original. This makes the task of bumping up difficult. It can also lead to bugs.

Proposal

Use the original variable names and function names as they are. I think this has the following pros and cons.

Pros

  • We can focus on comparing only important logic, so work efficiency at bump up will be improved.
  • We can eliminates task of renaming when forking from the original.
  • We can clarify the difference in logic from the original.

Cons

  • It can be mistaken for using tendermint.

For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned

ulbqb avatar Sep 15 '22 09:09 ulbqb

@ulbqb , Is it completed?

zemyblue avatar Nov 01 '22 05:11 zemyblue

We will substitute cmt, cometbft for oc, ostracon

tkxkd0159 avatar Nov 01 '23 02:11 tkxkd0159