Finn Woelm

Results 39 comments of Finn Woelm

Temporary fix is to simply disable the diff previews in the review mode. That deescalates the issue from `bug` to `enhancement`. :+1: See: #282

After implementation of #269, we should create a few proposals for what this could look like and then touch base with Babila and ask for his feedback.

We can extract plain text from .pptx files (which Google Slides converts to when downloaded): ``` file = File.new(Rails.root.join('tmp', 'pres.pptx')) html = Henkei::Server.extract_html(file) parsed = Nokogiri::HTML.parse(html) value.css('.slide-content').each_with_index { |x, i|...

This is what the diff could look like side-by-side. ![screenshot_2019-02-04 openly 2](https://user-images.githubusercontent.com/7606194/52218344-70f8a800-28d5-11e9-9f29-58364eb077a9.png)

Note: This issue will become irrelevant once we transition to React and views are no longer handled by Rails.

For dropping `parent_id`, we need to check its consequences. The `parent_id` here is a reference to a VCS::FileInBranch. It is **not** the same as the `parent_id` in `current_version` which refers...

To do this, we should probably add a boolean to the VCS::Diff column called `was_previously_committed`. Then showing `restored` vs `added` just requires a check of the column.

Alternative approach: Confirmation email is only sent to the new email address but email change must be confirmed by password. This allows for at least partial validation. It leaves a...

Pretty sure there is still no native i18n support for GitHub Pages: https://github.com/github/pages-gem/issues/401 :sob: