fine-uploader icon indicating copy to clipboard operation
fine-uploader copied to clipboard

Supporting multiple languages

Open NamespaceValentine opened this issue 9 years ago • 4 comments

Our site uses multiple languages and we have to translate everything in house. You allow some plain text overrides (text and retry and whatnot), but there are several error messages that you pop up that you dont currently allow overrides on. I dont know how feasible it is given your architecture, but it would be very useful if any English phrase you propagate allows an override of it's text.

NamespaceValentine avatar Feb 11 '16 18:02 NamespaceValentine

Can you please list the messages that are not currently replaceable?

rnicholus avatar Feb 12 '16 02:02 rnicholus

A for instance is: Received an empty or invalid response from the server!

Propagated from https://github.com/FineUploader/fine-uploader/blob/master/client/js/s3/request-signer.js line 302. Some errors like this are string literals embedded in the code with no option override.

NamespaceValentine avatar Feb 12 '16 07:02 NamespaceValentine

Thanks for the update. I'll keep this in mind for a future version.

rnicholus avatar Feb 16 '16 04:02 rnicholus

I think this one cannot be overridden also: "XHR returned response code " + xhr.status fine-uploader.js line 2814 and error messages inside drawThumbnail() function probably too.

slava-uxd avatar Mar 03 '16 09:03 slava-uxd