Finbuckle.MultiTenant icon indicating copy to clipboard operation
Finbuckle.MultiTenant copied to clipboard

Updated claims strategy to work with multiple authentication schemes

Open JonasDev17 opened this issue 1 year ago • 4 comments

I have tested this as a custom strategy and it works. Unfortunately its a breaking change though so it might not be viable as a PR.

JonasDev17 avatar Oct 29 '23 09:10 JonasDev17

@dotnet-policy-service agree

JonasDev17 avatar Oct 29 '23 09:10 JonasDev17

Or as you mentioned in #765 changing the the claim strategy to transient or scoped should work too without introducing a breaking change.

JonasDev17 avatar Oct 29 '23 10:10 JonasDev17

Thanks and thanks for the sponsorship!

Based on this PR I’m guessing you found the workaround I alluded to. Cheers!

AndrewTriesToCode avatar Nov 02 '23 01:11 AndrewTriesToCode

Just an update will be looking at this for next release.

AndrewTriesToCode avatar Jan 24 '24 03:01 AndrewTriesToCode

@JonasDev17 hi there, I didn't realize a different PR would cause a merge conflict with your PR. Would you be able to resolve the conflicts? I will merge it ASAP.

AndrewTriesToCode avatar Apr 23 '24 03:04 AndrewTriesToCode

Looking into this and I think instead I will close this PR and address this as a part of moving most strategies to transient scope.

AndrewTriesToCode avatar Apr 28 '24 15:04 AndrewTriesToCode