Finbuckle.MultiTenant icon indicating copy to clipboard operation
Finbuckle.MultiTenant copied to clipboard

Options builder support (#672)

Open AndrewTriesToCode opened this issue 2 years ago • 5 comments

  • Implement support for OptionsBuilder

  • Reverted changes to TenantConfigureNamedOptions

  • Restored commented test

  • Removed dependencies


AndrewTriesToCode avatar Aug 12 '23 18:08 AndrewTriesToCode

rebasing

AndrewTriesToCode avatar Nov 14 '23 01:11 AndrewTriesToCode

Ok @goldsam sorry for the delay. I'm active on this again. Thanks for the head start. I am going to make a few design changes but I really like the options wrapper -- I think I won't need a custom options factory anymore with this. I also like your Options Builder related code. I will probably slightly reformat some method names.

I am going to deprecate WithPerTenantOptions on MultiTenantBuilder in favor of ConfigurePerTenant variants directly on IServiceCollection. I hope to get this out soon. I won't be able to work on it really over Thanksgiving week so I will try to get it there this week. That will make Finbuckle Options very aligned with the vanilla ones in terms of naming and use for regular options and options builder with DI.

Thanks again.

AndrewTriesToCode avatar Nov 14 '23 07:11 AndrewTriesToCode

@AndrewTriesToCode Thank you so much! Glad my contribution was welcome.

goldsam avatar Nov 16 '23 18:11 goldsam

I'm looking forward to switching to the ConfigurePerTenant method. I have a use case that depends on being able to add the options conditionally, outside of the .AddMultiTenant configuration. This PR looks to help achieve that nicely.

mikecowgill avatar Dec 30 '23 04:12 mikecowgill

Glad to hear it will help you. I’m on vacation this week but will prioritize it shortly. I still need to update the docs to reflect the changes and consider tests.

AndrewTriesToCode avatar Dec 30 '23 15:12 AndrewTriesToCode

It looks like you're closing in on the finish line 🥳🎉

goldsam avatar Feb 28 '24 23:02 goldsam

Getting there. I apologize for the slow cadence. I’m going to lump in a few other breaking changes and get this out in March.

AndrewTriesToCode avatar Feb 29 '24 18:02 AndrewTriesToCode

:tada: This PR is included in version 7.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

AndrewTriesToCode avatar Apr 21 '24 20:04 AndrewTriesToCode