Options builder support (#672)
-
Implement support for OptionsBuilder
-
Reverted changes to TenantConfigureNamedOptions
-
Restored commented test
-
Removed dependencies
rebasing
Ok @goldsam sorry for the delay. I'm active on this again. Thanks for the head start. I am going to make a few design changes but I really like the options wrapper -- I think I won't need a custom options factory anymore with this. I also like your Options Builder related code. I will probably slightly reformat some method names.
I am going to deprecate WithPerTenantOptions on MultiTenantBuilder in favor of ConfigurePerTenant variants directly on IServiceCollection. I hope to get this out soon. I won't be able to work on it really over Thanksgiving week so I will try to get it there this week. That will make Finbuckle Options very aligned with the vanilla ones in terms of naming and use for regular options and options builder with DI.
Thanks again.
@AndrewTriesToCode Thank you so much! Glad my contribution was welcome.
I'm looking forward to switching to the ConfigurePerTenant method. I have a use case that depends on being able to add the options conditionally, outside of the .AddMultiTenant configuration. This PR looks to help achieve that nicely.
Glad to hear it will help you. I’m on vacation this week but will prioritize it shortly. I still need to update the docs to reflect the changes and consider tests.
It looks like you're closing in on the finish line 🥳🎉
Getting there. I apologize for the slow cadence. I’m going to lump in a few other breaking changes and get this out in March.
:tada: This PR is included in version 7.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: