Financial-Times
Hide podcast app launchers on desktop
Hello, this is my first foray into x-dash, so it's very possible I've done something obvious incorrectly. Please be vigilant when reviewing this PR!
We have had customer feedback that these buttons don't do anything on desktop and it is a concern that we are losing out on opportunities for engagement by showing people broken buttons.
This commit:
- Uses a media query to hide the app launcher buttons on desktop as they don't work
- Introduces an oGrid dependency to get the standard breakpoint for desktop
If this is your first x-dash pull request please familiarise yourself with the contribution guide before submitting.
I don't know how x-dash manages Origami dependencies. This is either a patch release because it is a very small change that won't break anything, or it is major because I have introduced a new Origami dependency which could break a dependency tree somewhere. Can anyone advise on this?
✅ Discuss features first (chatted with @robsquires) ✅ Update the documentation ✅ No hacks, experiments or temporary workarounds
- Reviewers are empowered to say no
- Reference other issues
- Update affected stories and snapshots
- Follow the code style ? Decide on a version (major, minor, or patch)
LGTM @alicebartlett Re. patch/minor, does it play nicely when you pull this branch into next-article and the app? I can try the app if that helps
OK - I've checked this on next-article and it looks good. @robsquires is gonna check on the app so I don't have to get all that set up, and then I think we're good!
