origami icon indicating copy to clipboard operation
origami copied to clipboard

Teaser/heading/container conundrum

Open luketudorgriffiths opened this issue 8 years ago • 2 comments

Problem: We only have one level of heading style for collections of things (which aren't necessarily teasers, think myft). They lack any hierarchy.

Proposal: Change the concept/name to o-container (or something similar) which has a levelled hierarchy of containers and associated typography styles. For example:**

S - For small teasers screen shot 2017-11-27 at 14 42 58

M - For those occasions where you need something in between (most commonly used on the article page screen shot 2017-11-27 at 14 43 45

L - what we currently have on homepage teasers (the class o-teaser-collection__heading--small is used on the article page but nowhere else) screen shot 2017-11-27 at 14 44 06

luketudorgriffiths avatar Nov 27 '17 14:11 luketudorgriffiths

(Sorry for the delay in getting to this...) Renaming seems sensible to me. Renaming the o-teaser collection component would mean:

  • Creating o-container
  • and then deprecating o-teaser-collection

My problem with this suggestion is that I think o-container is probably too generic for this component. looking at the homepage there is plenty of stuff that is in other types of container but isn't covered by this component.

alicebartlett avatar Dec 05 '17 14:12 alicebartlett

Could possibly relate to/include https://github.com/Financial-Times/o-teaser-collection/issues/16?

gvonkoss avatar Jan 15 '18 11:01 gvonkoss