n-makefile icon indicating copy to clipboard operation
n-makefile copied to clipboard

[WIP] add whitesource to Makefile

Open andygnewman opened this issue 8 years ago • 6 comments

Need to check a couple of things about how whitesource writes reports (overwrites npm report with bower report) before spreading this out more widely.

Have created a PR for the required changes to Whitesource

andygnewman avatar Aug 11 '16 15:08 andygnewman

+1

matthew-andrews avatar Sep 12 '16 08:09 matthew-andrews

Unfortunately Whitesource rejected the PR and their proposed solution is to have a separate config file for each package manager (bower & npm).

So changes here are;

  • create two whitesource config json files (npm & bower)
  • move check for package.json / bower.json into the config creation rather than executing whitesource
  • add custom file path to each execution

andygnewman avatar Sep 21 '16 14:09 andygnewman

http://docs.whitesourcesoftware.com/display/serviceDocs/NPM+Plugin

andygnewman avatar Sep 21 '16 14:09 andygnewman

still +1 from me

matthew-andrews avatar Sep 22 '16 07:09 matthew-andrews

Haven't had the opportunity to test it locally yet - will do that before merging.

andygnewman avatar Sep 22 '16 07:09 andygnewman

OK, have tested locally, however when Whitesource released the latest versions (which allowed for the different reports for bower / npm packages), I discovered (after much head scratching) that they'd saved it with Windows/DOS line endings rather than Unix, so the command line wasn't operating.

Have raised it with them.

But did change it locally and tested and all works as expected.

Plus have put together a little Wiki page in n-Makefile describing how to enable Whitesource for an app https://github.com/Financial-Times/n-makefile/wiki/Whitesource.

Will hold off merging in till we get working Whitesource modules.

andygnewman avatar Sep 22 '16 15:09 andygnewman