dotcom-page-kit icon indicating copy to clipboard operation
dotcom-page-kit copied to clipboard

Published 20 hours ago • verified publisher icon Financial-Times

[WIP] Add CSS Loading doc to Design Decisions

Open andygout opened this issue 5 years ago • 2 comments

SHOULD NOT BE MERGED UNTIL THE CONCEPTS IT DESCRIBES (PRs BELOW) HAVE BEEN MERGED

Describes work done in these PRs:

  • https://github.com/Financial-Times/dotcom-page-kit/pull/611
  • https://github.com/Financial-Times/dotcom-page-kit/pull/636

andygout avatar Oct 28 '19 10:10 andygout

The associated pull requests are merged, what needs to get done to get this in, can I help?

NickColley avatar May 13 '20 16:05 NickColley

I think two checks to make before merging this would be:

  • Perform the check described in this comment to ensure that what this PR's changes describe are still the case: https://github.com/Financial-Times/dotcom-page-kit/pull/637/files#r340544865.
  • Ensure that what is described in this PR comment is reflected in this PR's changes (i.e. that we are not generating separate blocking/non-blocking CSS bundles for the shared styles); I am pretty sure this will be the case but worth double-checking.

andygout avatar May 14 '20 07:05 andygout