mkcert
mkcert copied to clipboard
FiloSottile
add CommonName to generated certificates
Adding a CN to the subject makes generated certificates usable in DSM (Synology).
I created a certificate, uploaded it to my DSM and are able to use it for example as "System default" certificate. Also DSM now shows a "Issued to:" value:
Without this patch, "Issued to:" was empty and the certificate was not selectable for any usages.
Fixes FiloSottile/mkcert#469
Hey @FiloSottile , just wondering if you've had a chance to take a look at this pull request? I think it's good to go, but let me know if there's anything else that needs to be done. Thanks!
@elexx I actually went ahead and built from source on Windows to add this pull request. I also have a Synology Disk Station and although it handled the cert imports fine on mine, I just liked having the CN label to easily differentiate between my different certs. Thanks for this!
And @FiloSottile, thank you for this awesome tool. I use it all the time.
I've built from source as well after applying the changes in the PR, but the certs still appear "blank" in Synology DS for me, as described in the initial comment buy @elexx. Unlike @LibbyJax I can't work with them in the UI either, they are unselectable for example in Security > Certificates > Settings where you would set a cert as the System default. Don't suppose either of you have any ideas?
Any idea why this PR hasn't been merged in?
add CN to generated certificates · elexx/mkcert@49fec4a https://github.com/elexx/mkcert/commit/49fec4a21908ddf9cb3600fed28ea9c6de8bca93
