Filippo Valsorda

Results 111 issues of Filippo Valsorda

### Discussed in https://github.com/FiloSottile/age/discussions/638 Originally posted by **dsemi** June 20, 2025 The age library API is currently implemented to allow for decrypting a Reader, or encrypting a Writer. I have...

Before the RC1 release, we should freeze a v2.0.0-rc.1 module. There are two small fixes that need to land before we freeze it, https://go.dev/cl/728504 and https://go.dev/cl/728503. Should be done between...

NeedsFix
release-blocker
Other

Before the final Go 1.26 release, we need to freeze a v2.0.0 module and remove the v2.0.0-rc.1 module. /cc @golang/release @golang/security

release-blocker
okay-after-rc1
Implementation

Currently, the -longtest TryBots run on CLs that touch crypto/tls, to run the slow-ish BoGo test suite. Also, cmd/dist runs the `GOFIPS140=$VERSION go test crypto/...` tests only in long mode....

Builders
new-builder

`fips140=only` from #70123 breaks any non-FIPS cryptography. Testing a mode designed to break things is tricky. Running the whole test suite is prohibitive. Instead, we should probably write a dedicated...

Testing
NeedsFix

ML-DSA-44, unlike -65 and -87, can reject due to ||ct0||∞ ≥ γ2. It doesn't look like we have test vectors for that. https://groups.google.com/a/list.nist.gov/g/pqc-forum/c/G8Zf0hC-uu0/m/Kb3qNJb0AwAJ has a very comprehensive set, unfortunately for...

Categorizing notes is sometimes very tricky, as some issues straddle the line. That takes time, and in my experience it was the slowest part of adding my ML-KEM vectors. Is...

In crypto code we often use ``` // sliceForAppend takes a slice and a requested number of bytes. It returns a // slice with the contents of the given slice...

false-positive

os/exec.Command returns a Cmd with only Path and Args filled out. That means that doing ``` cmd := exec.Command("foo") cmd.Env = append(cmd.Env, "FOO=bar") ``` is always equivalent to ``` cmd...

needs-triage