gvt icon indicating copy to clipboard operation
gvt copied to clipboard

Consider allowing leading underscores in directory names

Open igorwwwwwwwwwwwwwwwwwwww opened this issue 8 years ago • 3 comments

I recently ran into a case of a package that would install fine via go get having unexpected behaviour when installing via gvt fetch. It turned out that the package I was trying to install had a directory starting with _ which gvt removes as per this logic.

This was rather unexpected, especially considering go get does not have an issue with it. I have opened a ticket with the project in question https://github.com/openzipkin/zipkin-go-opentracing/issues/42 but also wanted to inquire if gvt should be a bit more permissive in this case -- as it is rather likely that other packages will have the same issue.

Regards, Igor

Quoting @basvanbeek in the ticket linked above:

As all the code under _thrift is generated I specifically prefixed with _ so it would not be included in tests, coverage, linting, etc.

Seems GVT includes omitting behavior to extend to pulling in code too which is rather strange as one would expect the VC to not include items that should be ignored.

If you agree, perhaps gvt could be more permissive in which files it removes?

Bump. :tulip: @FiloSottile

Lyoness avatar Jan 18 '17 13:01 Lyoness

Hi, I forked a patch version to address this issue. See https://github.com/FiloSottile/gvt/issues/91

hiroshi avatar Apr 07 '17 01:04 hiroshi