age icon indicating copy to clipboard operation
age copied to clipboard

feat: move tui code to tui package

Open brianmcgee opened this issue 1 year ago • 11 comments

It makes PluginTerminalUI available for sops (and other third parties) to support plugins more easily.

brianmcgee avatar Oct 02 '24 11:10 brianmcgee

From the SOPS point of view, having this as a reusable package would be really great! Basically copy'n'pasting that code over (and keeping it up-to-date) would IMO be a last-resort solution, which I'd like to avoid.

felixfontein avatar Oct 02 '24 17:10 felixfontein

CI needs a fix:

Error: cmd/age-keygen/keygen.go:161:13: non-constant format string in call to log.Printf

Mic92 avatar Oct 12 '24 09:10 Mic92

  • https://github.com/FiloSottile/age/pull/589

0x2b3bfa0 avatar Oct 18 '24 04:10 0x2b3bfa0

I missed that the static checks needed to be fixed. I just cherry-picked https://github.com/FiloSottile/age/pull/589 into this branch.

@FiloSottile, it would be great if we could get this merged :pray:

brianmcgee avatar Oct 18 '24 06:10 brianmcgee

Friendly ping

Mic92 avatar Nov 09 '24 09:11 Mic92

I guess a long-term fork, it is than. Someone else interested in maintaining it? We could create some org that contains both age and sops with this feature. We would probably just need to merge with upstream every once in a while.

Mic92 avatar Nov 29 '24 16:11 Mic92

@FiloSottile any kind of feedback (like whether this has a chance of eventually getting merged) would be great!

felixfontein avatar Nov 30 '24 08:11 felixfontein

+1 would be great to have this merged

visualphoenix avatar Dec 11 '24 17:12 visualphoenix

@brianmcgee hey looks like #589 just got merged!

NovaViper avatar Dec 18 '24 15:12 NovaViper

@Mic92 I will be maintaining a fork from this PR if anyone else is interested.

tahlonbrahic avatar Jan 15 '25 03:01 tahlonbrahic

I’ve merged this PR at https://github.com/age-sops/age

Feel free to make PRs with any improvements you have

Enzime avatar Jan 15 '25 03:01 Enzime