stacked icon indicating copy to clipboard operation
stacked copied to clipboard

ReactiveServiceMixin and notifyListeners documentation

Open merfire opened this issue 5 years ago • 7 comments

In documentation for ReactiveServiceMixin, the example uses reactive value from observable_ish package. In the answer for issue #88, notifyListeners was recommended way without reactive values. My question is what is the current state of this, should notifyListeners be in documentation instead of reactive values as the default solution? It is also mentioned that reactive values will be removed, does that mean functions that use of observable_ish package should be deprecated, and later observable_ish can be fully removed from stacked?

merfire avatar Mar 11 '21 11:03 merfire

@merfire yes, it should be in the documentation.

And yes, i'd like to have all references to observable_ish removed from the readme and the examples.

FilledStacks avatar Mar 11 '21 14:03 FilledStacks

+1 on this - I had to click into listenToReactiveValues to see that my RxValues were no longer being listened to, since the documentation has not been updated to declare that only ReactiveValue and ReactiveList are now: Screen Shot 2021-04-09 at 10 49 48 AM

JayPerfetto avatar Apr 09 '21 17:04 JayPerfetto

@JayPerfetto totally get that. We're paying for open source support now because it's becoming quite difficult to keep up with all the issues myself.

I'm trying my best :) We will do a documentation run soon and add everything in that's missing

FilledStacks avatar Apr 12 '21 16:04 FilledStacks

Its okay! this package still rules :D any plans to add a ReactiveMap class? I'm using ReactiveValue<Map<thing, thing>> for now but there was an RxMap (it was also unsuported by old-stacked) in observable_ish that might be useful

JayPerfetto avatar Apr 12 '21 16:04 JayPerfetto

@JayPerfetto no plans right now, I want to clear all these issues first then move on to new things.

FilledStacks avatar Apr 13 '21 07:04 FilledStacks

I'm super super appreciative of the package(s) you've created!! Thank you thank you thank you!

However I'm glad I looked at this post as I've been working on resolving my observable_ish package not working for a week now. Glad I found this, resolved my problem in minutes. I understand you must be busy, IMHO we should just quickly post a link to this post letting people know it has been removed from the latest package.

EricPHassey avatar Apr 24 '21 06:04 EricPHassey

Requirements

Docs

  • Write documentation that showcase how to use reactive services with ViewModels
  • Remove references to observable_ish
  • Remove references to ReactiveValues

Code

  • Deprecate ReactiveValues type

FilledStacks avatar May 16 '23 09:05 FilledStacks