findup icon indicating copy to clipboard operation
findup copied to clipboard

Comparison of file paths shouldn't use raw strings

Open harrysarson opened this issue 8 years ago • 0 comments

The path modules normalises strings to the operating system (e.g. / is replaced by \\ on windows).

Therefore comparing paths by using string comparison is dangerous, I think this may be the cause of issue #17.

Possibly using https://nodejs.org/api/path.html#path_path_relative_from_to may be a more robust to compare file paths.

harrysarson avatar Feb 14 '17 00:02 harrysarson