EarTrumpet icon indicating copy to clipboard operation
EarTrumpet copied to clipboard

Published 20 hours ago • verified publisher icon File-New-Project

Improved consistency with Light Theme

Open krlvm opened this issue 2 years ago • 3 comments

EarTrumpet's light theme is not very consistent with native flyouts and is very difficult to see with particular accent colors.

Before After

krlvm avatar Jun 03 '22 17:06 krlvm

Actually, none of the colors are quite right. We need to instead harvest the correct values for Windows 10 and Windows 11 from the WinUI 2.x/3.x libraries. (Or port WPF XAML to WinRT/WinUI XAML and switch to native controls.) Both not trivial.

riverar avatar Jun 03 '22 17:06 riverar

I got the real color and alpha values of the standard flyouts by attaching a Visual Studio debugger to the ShellExperienceHost and using the Live Visual Tree Inspector - they do match, at least until the UI update to Windows 11.

I'll try porting them to EarTrumpet later.

krlvm avatar Jun 03 '22 17:06 krlvm

Right, didn't mean your PR specifically was wrong. I just mean in general we have an overall need to port these styles https://github.com/microsoft/microsoft-ui-xaml/tree/main/dev/CommonStyles

riverar avatar Jun 03 '22 17:06 riverar

Hey @krlvm, do you mind rebasing/resolving the merge issue here? Looks like some stray commits got in when you retargeted. Thanks!

riverar avatar Oct 04 '22 03:10 riverar

Done

krlvm avatar Oct 04 '22 10:10 krlvm

Thanks @krlvm and apologies for the delay. Will be cleaning the repository up here shortly!

riverar avatar Oct 08 '22 00:10 riverar