EarTrumpet icon indicating copy to clipboard operation
EarTrumpet copied to clipboard

Drag&Drop to change app device (discussion #662)

Open Masurov opened this issue 2 years ago • 5 comments

As discussed in https://github.com/File-New-Project/EarTrumpet/discussions/662, here is the drag&drop feature.

I used gong wpf dragdrop package to make it easier. Feel free to tell me if the project guidelines are not followed.

Masurov avatar Apr 15 '22 21:04 Masurov

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 15 '22 21:04 CLAassistant

Will review this, but one question that immediately comes to mind: How does a user return an app to the state in which it follows the "default" device? I feel like this may greatly confuse users as apps will start becoming attached to specific devices.

riverar avatar May 05 '22 23:05 riverar

Good point ! I naively duplicated the "transfer application" button command to drag and drop action. You're right, this will encourage users to force application output on a device.

To be self explanatory, EarTrumpet could show that the current application-device assigment is forced or not. What about adding a "pinned" clickable icon on a application if it is assigned on this specific device ? Clicking on the pin button would reassign the application on default device and remove the pin icon.

Would be interested in your thought.

Masurov avatar May 06 '22 17:05 Masurov

Something like this but I don't know exactly where to put the pin

image

Masurov avatar May 06 '22 19:05 Masurov

After starting a drag event, you could spawn a drop target that says default on it, that is hidden otherwise.

Otherwise, dragging to the current default could overlay 2 drop targets, default and per device.

image

You could also use the pin iconography, and show all devices that are pinned differently, vs things like system sounds, discord, and steam which are annoyingly using all devices.

ryantheleach avatar Jul 27 '22 15:07 ryantheleach

Is this ever going to be implemented?

sphinx9 avatar Oct 22 '22 18:10 sphinx9

Will review this, but one question that immediately comes to mind: How does a user return an app to the state in which it follows the "default" device? I feel like this may greatly confuse users as apps will start becoming attached to specific devices.

Maybe something like this (on drag event):

image

And instead of an icon it might be interesting to do it like this:

image

The line at the left side could either mean it being attached to the default device or mean it's detached.

yani avatar Dec 26 '22 10:12 yani

Why this still not updated? How can I get this version of eartrumpet?

bigplayer-ai avatar Dec 30 '22 10:12 bigplayer-ai

I compiled this but I wish if you can add hovering text over the app icon to know the source of it. For example multiple chrome windows opened will show only chrome icons it is hard to know which chrome window you want to switch it's audio.

bigplayer-ai avatar Jan 10 '23 13:01 bigplayer-ai

@bigplayer-ai There are still outstanding design questions / issues to resolve and it hasn't been high priority to resolve because this core functionality already exists (right-click an app).

riverar avatar Jan 10 '23 17:01 riverar

@bigplayer-ai There are still outstanding design questions / issues to resolve and it hasn't been high priority to resolve because this core functionality already exists (right-click an app).

this is taking forever :( Can you help me get .msi to install this? my compilation/build failed :(

bigplayer-ai avatar Jan 14 '23 14:01 bigplayer-ai

This feature still needs design work and will start falling behind with some major merges coming up. Closing for now.

riverar avatar Jan 28 '23 04:01 riverar