Philippe Rivière

Results 975 comments of Philippe Rivière

I've reported the Date issue at https://github.com/apache/arrow/issues/40718. I think it is orthogonal to this PR, since I can get the same error with Plot#main and an arrow table ~~—though it...

Tested with https://github.com/apache/arrow/pull/40725 everything works smoothly (except for test "mark data parallel to facet data triggers a warning" which is not relevant). Thanks for the super quick fix @trxcllnt and...

In the PR that fixes the Date bug (https://github.com/apache/arrow/pull/40725), @domoritz also changes the `.get(i)` value accessor into `.at(i)`, which means that everywhere we use `(array)[i]` vs `(arrow vector).get(i)`, we could...

continued in (and superseded by) #2115

If I activate this option in the repo and run `yarn test:tsc`, I get `Found 66 errors in 35 files.` ```diff diff --git a/tsconfig.json b/tsconfig.json index 668c98ef..7978fb37 100644 --- a/tsconfig.json...

My suggestion (option 3 if you will) is to export a specific type (e.g. `CurveAuto`) and to use it in all the places :-) I don't see us doing only...

@pdebruic we could open a new discussion about this. By default the interpolation is done by SVG, and Plot only passes [path commands](https://observablehq.com/@d3/d3-path) to connect the (actual) dots. To find...

More experimentation: I've pushed another strategy, even though I'm not convinced it's better. Maybe it will give us new ideas.

Sounds promising! (Also, somehow related to #1132 / #1109, for the attribution of a unique id.) I'm trying to think about how we would express these gradients in the API....