javafx-gradle-plugin
javafx-gradle-plugin copied to clipboard
FibreFoX
Current InnoSetup on Windows is incompatible with the default .iss file MinVersion value
After getting past #146, I am running into another issue on Windows where the current release of InnoSetup doesn't like the MinVersion=0,5.1 value inside of the default .iss template file. It complains that the version is too old.
Minimum NT version specified by MinVersion must be at least 6.0. (Windows 2000/XP/Server 2003 are no longer supported.)
I am aware that I can work around this by creating my own .iss file and changing 0,5.1 to 0,6.0. The problem with that is that if I go that route I believe I need to maintain that .iss file myself moving forward as opposed to letting it get auto-generated. Is there a way to override a single key/value pair within the default .iss file only, and let it auto-generate the rest of the file?
After digging into this more I'm not sure if this is an issue with javafx-gradle-plugin or the JDK. But, for anyone else running into this issue, I've found two ways to work around it.
1.) Use InnoSetup 5 rather than InnoSetup 6
2.) Copy the default template.iss file from com\oracle\tools\packager\windows\template.iss (I grabbed it here) and use it as a basis for a custom .iss file. You can change just the fields you want to, including the MinVersion field, which I changed to MinVersion=0,6.0. This basically just using the javapackager drop-in-resource mechanism.
:( this is a dependency of the javapackager itself, so nothing that I can do about. The official documentation of JDK 8 says Inno Setup 5 or later, probably only inside the 5.x-version-family.
As that template-file gets provided via the JDK, there is not that much that I can do about out-of-the-box.
I can confirm, that manually adjusting that template and placing it in src/deploy/package/... is the way to go here :( I think this probably will not be "backported" in the official JDK to support inno-setup 6.
Just for reference: https://stackoverflow.com/questions/59158417/io-exception-in-java-packager-exec-failed-with-code-2-command