Editing comments does not work

[bluebirch]

Steps to reproduce

1. Select Commentator: Add comment from command palette.
2. Double click the empty comment box in the left-right margin.
3. Type something.
4. Click somewhere outside the comment box.

Current behaviour

The comment vanishes.

Expected Behavior

The comment is saved.

Am I missing something? How are comments supposed to be saved after editing them?

Which Operating Systems are you using?

Linux

Obsidian App Version

1.8.10

Obsidian Installer Version

1.8.10

Commentator Plugin Version

0.2.4

Enabled Plugins

BRAT, Code Editor Shortcuts, Git, Linter, Multi Properties, Multi Tag, Neighbouring Files, Projects, Shell Commands, Tag Wrangler

Additional Checks

• [x] I tried reloading Obsidian to see if the bug persists.
• [x] I have tried to reproduce the bug with all other plugins disabled.
• [x] I tried to reproduce the error in the sandbox vault.
• [x] I have checked other issues to see if something similar has already been reported.

[Fevol]

Hey, thanks for opening this issue!

I saw your post in the Discord thread, but I should also respond here: when you edit a comment in the current version of the plugin, the changes will only be applied if you press Ctrl/Cmd + Enter.

As it is currently implemented, it is indeed poorly communicated and confusing, so some changes are warranted.

I'd be interested in hearing which of the following options you would prefer:

1. Blurring or escaping will always save the changes
2. Add a Submit and Cancel button or icons (similar to Google Docs and Word)

[bluebirch]

Yes, sorry, I found the Discord channel after I submitted this issue. I normally don't use Discord so I continue the conversation here.

Yes, Ctrl+Enter works, it never occurred to me to try that.

I would prefer the Submit and Cancel buttons, that way the user interface makes it obvious what is expected from the user. Blurring/escaping could perhaps trigger a dialogue asking if the user wants to keep or discard the changes.

[Glaconius]

Sorry to barge in. If I just wrote a comment, I'd imagine in 99% of the cases I'd want to keep it. Having to confirm that with a button interaction every single time would feel more like a hindrance, especially considering that to erase the comment (on windows) I just need to go ctrl+a and then backspace. While comments could have a X button to erase them, I think that option 1 would be ideal.

[gzz2000]

Sorry to barge in. If I just wrote a comment, I'd imagine in 99% of the cases I'd want to keep it. Having to confirm that with a button interaction every single time would feel more like a hindrance, especially considering that to erase the comment (on windows) I just need to go ctrl+a and then backspace. While comments could have a X button to erase them, I think that option 1 would be ideal.

I agree. Maybe just add a cancel button and make the default behavior as save is the best